Generate complete bindings to libzmq #232
Conversation
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #232 +/- ##
===========================================
- Coverage 91.82% 74.90% -16.93%
===========================================
Files 9 11 +2
Lines 367 526 +159
===========================================
+ Hits 337 394 +57
- Misses 30 132 +102 ☔ View full report in Codecov by Sentry. |
|
Overall, I'm in favor of this, though I haven't had a chance to review it in detail. |
|
I made another change to the internals in 56d3a9b to force using |
JamesWrigley
force-pushed
the
full-bindings
branch
from
ef30b30 to
ad78bde
Compare
|
Rebased the branch, and modified the generated bindings to use |
JamesWrigley
force-pushed
the
full-bindings
branch
from
c13987d to
5be48d2
Compare
|
(bump) |
JamesWrigley
force-pushed
the
full-bindings
branch
from
5be48d2 to
f5ceaa5
Compare
Along with some extra methods we need for the Message type.
Using plain _Message's with most of these functions is likely incorrect.
JamesWrigley
force-pushed
the
full-bindings
branch
from
f5ceaa5 to
cd4473b
Compare
This is a rather invasive change to use Clang.jl to generate bindings for everything in
zmq.h, and then use those bindings in the rest of the library. My motivation for doing this is to make it easier to call the libzmq functions, both for us and for anyone who wants to use the low-level functions (e.g. for things we haven't explicitly wrapped). It's also nice to have the constants generated for us.It touches a lot of internals so this would definitely benefit from a review from someone more familiar with them 😅 In particular the code for
_MessageandMessage, which took me a while to understand. I've written down my understanding of how that works in the comments ofgen.jl. For the reviewers: I've tried to keep the commits atomic, so it might be easiest to review the commits one-by-one.I don't think it's quite ready to merge yet because I'd like to add some more docs, but it should be ready for review.CC @stevengj, @vtjnash